Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Menzel.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51775 )
Change subject: chromeec: Fix google_chromeec_status_check timeout
......................................................................
Patch Set 6:
(3 comments)
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/51775/comment/7b8ca234_1545e496
PS4, Line 98: *
nit: spaces around *
Done
https://review.coreboot.org/c/coreboot/+/51775/comment/c9a98c91_2464a73f
PS4, Line 105: return 0;
Print the stopwatch value in a spew message?
This will be noisy.
https://review.coreboot.org/c/coreboot/+/51775/comment/f5266df2_baafeed6
PS4, Line 108:
Please print a warning/error with the timeout value.
All the calls to this function already print a timeout error.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I363ff7453bcf81581884f92797629a6f96d42580
Gerrit-Change-Number: 51775
Gerrit-PatchSet: 6
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Apr 2021 17:17:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment