Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19501 )
Change subject: lib/edid.c: Allow use of when not NGI ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/19501/1/src/device/Kconfig File src/device/Kconfig:
PS1, Line 28:
It's futile here since the `y` above takes precedence. Why did you
Indeed, should be fixed in v2.
https://review.coreboot.org/#/c/19501/2/src/lib/edid.c File src/lib/edid.c:
Line 1749: #if IS_ENABLED(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT)
Why would it need another guard?
multiple definitions which conflicts with src/device/oprom/realmode/x86.c. Could be it is the wrong guard though...