Change in coreboot[master]: mb/google/hatch: Stop AP power-off on Puff & variants cr50 updates
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42497 )
Change subject: mb/google/hatch: Stop AP power-off on Puff & variants cr50 updates ......................................................................
mb/google/hatch: Stop AP power-off on Puff & variants cr50 updates
Fix Puff and its variants to not shutdown the AP before the cr50 reboot. This is the same approach that Sarien do to remain on during a cr50 cycle.
BUG=b:154071064 BRANCH=none TEST=none
Change-Id: I5f92b4f769654b67c10c91e4cc7b2bce785e302f Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/42497/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 5821b76..3bbe4b1 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -99,6 +99,10 @@ string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-puff-16MiB.fmd" if BOARD_ROMSIZE_KB_16384 default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-puff-32MiB.fmd" if BOARD_ROMSIZE_KB_32768 + +config POWER_OFF_ON_CR50_UPDATE + bool + default n endif
config MAINBOARD_DIR
Hello Sam McNally, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42497
to look at the new patch set (#2).
Change subject: mb/google/hatch: Stop AP power-off on Puff & variants cr50 updates ......................................................................
mb/google/hatch: Stop AP power-off on Puff & variants cr50 updates
Fix Puff and its variants to not shutdown the AP before the cr50 reboot. This is the same approach that Sarien do to remain on during a cr50 cycle.
BUG=b:154071064 BRANCH=none TEST=none
Change-Id: I5f92b4f769654b67c10c91e4cc7b2bce785e302f Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/42497/2
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42497 )
Change subject: mb/google/hatch: Stop AP power-off on Puff & variants cr50 updates ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42497 )
Change subject: mb/google/hatch: Stop AP power-off on Puff & variants cr50 updates ......................................................................
mb/google/hatch: Stop AP power-off on Puff & variants cr50 updates
Fix Puff and its variants to not shutdown the AP before the cr50 reboot. This is the same approach that Sarien do to remain on during a cr50 cycle.
BUG=b:154071064 BRANCH=none TEST=none
Change-Id: I5f92b4f769654b67c10c91e4cc7b2bce785e302f Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42497 Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 05bc711..86a8c66 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -99,6 +99,10 @@ string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-puff-16MiB.fmd" if BOARD_ROMSIZE_KB_16384 default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-puff-32MiB.fmd" if BOARD_ROMSIZE_KB_32768 + +config POWER_OFF_ON_CR50_UPDATE + bool + default n endif
config MAINBOARD_DIR
-
Edward O'Callaghan (Code Review) -
Sam McNally (Code Review)