Attention is currently required from: Jian Tong, Karthik Ramasubramanian, Kun Liu, Shelley Chen.
Paul Menzel has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/84412?usp=email )
Change subject: mb/google/brox/var/lotso: Fix goodix touchscreen power off sequence
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84412/comment/bdd9d400_8dfe69c1?usp... :
PS3, Line 9: Power off
Poweroff
https://review.coreboot.org/c/coreboot/+/84412/comment/cfe4f5b1_8cf5f32d?usp... :
PS3, Line 9: Power off does not seem to use the ACPI _OFF function, but rather the
: smihandler.
How can this be verified for sure? We try to avoid SMI, don’t we?
https://review.coreboot.org/c/coreboot/+/84412/comment/3f30561e_f50e89ec?usp... :
PS3, Line 11: power off
poweroff
https://review.coreboot.org/c/coreboot/+/84412/comment/9c58c756_6770e59d?usp... :
PS3, Line 14: TEST=emerge-brox coreboot
Did you test it on the device?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84412?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0108be4e5e7c0265aae0f16fd4e2b7cbe5936112
Gerrit-Change-Number: 84412
Gerrit-PatchSet: 3
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 23 Sep 2024 06:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No