Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56809 )
Change subject: sb/amd/pi/hudson/soc/gpio: add SOC_GPIO_TOTAL_PINS definition ......................................................................
sb/amd/pi/hudson/soc/gpio: add SOC_GPIO_TOTAL_PINS definition
EGPIO132 is the last documented GPIO on the GPIO controller in the NDA version of the BKDG for AMD Family 16h Models 30h-3Fh Processors (#52740 Rev 3.06) which is the only SoC using this code, so define SOC_GPIO_TOTAL_PINS as 133, since the internal GPIO numbers are 0-indexed. This definition will be needed the subsequent patch that'll add the remote GPIO support to the common AMD GPIO code to make sure that the compiler can optimize out the code path needed to support the remote GPIO access which isn't available on this platform anyway.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I877d462c5e753c9bbb3461dbb10cde2adc2cb12c Reviewed-on: https://review.coreboot.org/c/coreboot/+/56809 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/southbridge/amd/pi/hudson/soc/gpio.h 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/southbridge/amd/pi/hudson/soc/gpio.h b/src/southbridge/amd/pi/hudson/soc/gpio.h index 10a47cb..6069ee0 100644 --- a/src/southbridge/amd/pi/hudson/soc/gpio.h +++ b/src/southbridge/amd/pi/hudson/soc/gpio.h @@ -6,4 +6,6 @@ /* <soc/gpio.h> must provide gpio_t. */ #include <amdblocks/gpio_banks.h>
+#define SOC_GPIO_TOTAL_PINS 133 + #endif /* SOC_GPIO_H */
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.