Change in ...coreboot[master]: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )

Change subject: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31133/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31133/1//COMMIT_MSG@7 
PS1, Line 7: Add SOC_INTEL_WHISKEYLAKE kconfig
           :
> Does it really help? It seems to be adding another config but is used always with SOC_INTEL_COFFEELA […]

there is some confusion by seeing board support.

CFL and WHL are different SOC from Intel side, in coreboot context both might look similar because its almost common code. But you can't ignore the fact that neither WHLRVP will boot with CFL SoC nor hatch board can have CFL SOC.

adding WHL config might not add any value bt it will be clear from user level to know soc details along with board

https://review.coreboot.org/#/c/31133/1//COMMIT_MSG@7 
PS1, Line 7: Add SOC_INTEL_WHISKEYLAKE kconfig
           :
> Same question here, we have separated WHL FSP already?

With CML release, we might have some common FSP between WHL and CML.

This patch is not to tell where FSP exist. as i said this to make notion clear about board. CFL != WHL in reality then why to select the same for all board ?