Uwe Poeche has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82734?usp=email )
Change subject: Makefile.mk: Use Walloc-size GCC option
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Actually we use on our build system ggc 13.2.0.
With that introduced cflag (why it introduced is not mentioned in commit message) we get gcc error: unrecognized command-line option '-Walloc-size'
Would it be better as in CB:82785 to introduce a check via util/xcompile/xcompile if the flag is supported?
The same could be relevant on CB:82736.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82734?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia26dcf097db125a5a734660d08d875459179241b
Gerrit-Change-Number: 82734
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Comment-Date: Tue, 02 Jul 2024 10:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No