Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Map PMC_GPE_DW to PMC_GPP values ......................................................................
mb/google/dedede: Map PMC_GPE_DW to PMC_GPP values
PMC_GPE_DW values should be mapped to PMC_GPP values because of which S3 wake from Trackpad is not functional.
Change-Id: I58ce3720e0fdeefb2c9440bb3006897ef80211ea Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/43949/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 7502489..e36d843 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -16,9 +16,9 @@ # - GPP_D0 - WWAN_HOST_WAKE # - GPP_D3 - WLAN_PCIE_WAKE_ODL # EC_AP_WAKE_ODL is routed to LAN_WAKE#/GPD02 & is part of DW3. - register "pmc_gpe0_dw0" = "GPP_B" - register "pmc_gpe0_dw1" = "GPP_C" - register "pmc_gpe0_dw2" = "GPP_D" + register "pmc_gpe0_dw0" = "PMC_GPP_B" + register "pmc_gpe0_dw1" = "PMC_GPP_C" + register "pmc_gpe0_dw2" = "PMC_GPP_D"
# EC host command ranges are in 0x800-0x8ff & 0x200-0x20f register "gen1_dec" = "0x00fc0801"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43949
to look at the new patch set (#2).
Change subject: mb/google/dedede: Fix S3 wake using trackpad for WaddleDoo ......................................................................
mb/google/dedede: Fix S3 wake using trackpad for WaddleDoo
Change-Id: I58ce3720e0fdeefb2c9440bb3006897ef80211ea Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/43949/2
Hello build bot (Jenkins), Maulik V Vaghela, Aamir Bohra, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43949
to look at the new patch set (#3).
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
mb/google/dedede: Fix S3 wake using trackpad
Configure TRACKPAD_INT_ODL pad reset config to DEEP and map PMC_GPE_DW to PMC_GPP values.
TEST=System should wake from S3 via trackpad
Change-Id: I58ce3720e0fdeefb2c9440bb3006897ef80211ea Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/43949/3
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede... PS3, Line 19: register "pmc_gpe0_dw0" = "PMC_GPP_B" : register "pmc_gpe0_dw1" = "PMC_GPP_C" : register "pmc_gpe0_dw2" = "PMC_GPP_D" Can you please check if these groups have non-conflicting IRQs.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/43949/4/src/mainboard/google/dedede... PS4, Line 52: DEEP I can see that with Deep - Pad configuration is not reset in S3. But there was a reason, something to do with IRQ routing, for which PLTRST was used.
Can you please confirm if this is working fine with S0ix?
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede... PS3, Line 19: register "pmc_gpe0_dw0" = "PMC_GPP_B" : register "pmc_gpe0_dw1" = "PMC_GPP_C" : register "pmc_gpe0_dw2" = "PMC_GPP_D"
Can you please check if these groups have non-conflicting IRQs.
Aamir, can you please elaborate on non-conflicting IRQs?
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede... PS3, Line 19: register "pmc_gpe0_dw0" = "PMC_GPP_B" : register "pmc_gpe0_dw1" = "PMC_GPP_C" : register "pmc_gpe0_dw2" = "PMC_GPP_D"
Aamir, can you please elaborate on non-conflicting IRQs?
I meant if the IRQ# of the GPIO groups(in GPIO DW1 registers) are not same for the listed groups(some groups have common IRQ#). But now if I think, it should be a dont' care ,since groups are individually mapped to GPE registers and triggers a SCI.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/43949/4/src/mainboard/google/dedede... PS4, Line 52: DEEP
I can see that with Deep - Pad configuration is not reset in S3. […]
Yes, Karthik. We have verified it to be working fine on Doo, Dee and Drawlat for both S0ix and S3 scenarios.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede... PS3, Line 19: register "pmc_gpe0_dw0" = "PMC_GPP_B" : register "pmc_gpe0_dw1" = "PMC_GPP_C" : register "pmc_gpe0_dw2" = "PMC_GPP_D"
I meant if the IRQ# of the GPIO groups(in GPIO DW1 registers) are not same for the listed groups(som […]
Ack
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43949/4//COMMIT_MSG@7 PS4, Line 7: mb/google/dedede: Fix S3 wake using trackpad Is there a bug report for this issue?
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43949/4//COMMIT_MSG@7 PS4, Line 7: mb/google/dedede: Fix S3 wake using trackpad
Is there a bug report for this issue?
No, we don't have a crosbug for this.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 4: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
mb/google/dedede: Fix S3 wake using trackpad
Configure TRACKPAD_INT_ODL pad reset config to DEEP and map PMC_GPE_DW to PMC_GPP values.
TEST=System should wake from S3 via trackpad
Change-Id: I58ce3720e0fdeefb2c9440bb3006897ef80211ea Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43949 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Aamir Bohra: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index e7c5656..13666ad 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -16,9 +16,9 @@ # - GPP_D0 - WWAN_HOST_WAKE # - GPP_D3 - WLAN_PCIE_WAKE_ODL # EC_AP_WAKE_ODL is routed to LAN_WAKE#/GPD02 & is part of DW3. - register "pmc_gpe0_dw0" = "GPP_B" - register "pmc_gpe0_dw1" = "GPP_C" - register "pmc_gpe0_dw2" = "GPP_D" + register "pmc_gpe0_dw0" = "PMC_GPP_B" + register "pmc_gpe0_dw1" = "PMC_GPP_C" + register "pmc_gpe0_dw2" = "PMC_GPP_D"
# EC host command ranges are in 0x800-0x8ff & 0x200-0x20f register "gen1_dec" = "0x00fc0801" diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index 9b60da1..d6a2d61 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -49,7 +49,7 @@ /* B2 : PROCHOT_ODL */ PAD_NC(GPP_B2, NONE), /* B3 : TRACKPAD_INT_ODL */ - PAD_CFG_GPI_IRQ_WAKE(GPP_B3, NONE, PLTRST, LEVEL, INVERT), + PAD_CFG_GPI_IRQ_WAKE(GPP_B3, NONE, DEEP, LEVEL, INVERT), /* B4 : H1_PCH_INT_ODL */ PAD_CFG_GPI_APIC(GPP_B4, NONE, PLTRST, LEVEL, INVERT), /* B5 : PCIE_CLKREQ0_N */
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43949/4//COMMIT_MSG@7 PS4, Line 7: mb/google/dedede: Fix S3 wake using trackpad
No, we don't have a crosbug for this.
Please describe the bug in more detail the next time.
-
Aamir Bohra (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Meera Ravindranath (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)