Attention is currently required from: Hung-Te Lin, Jiaxin Yu, Ruihai Zhou, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email )
Change subject: mb/google/corsola/var/chinchou: Configure I2C and I2S interface for ALC5650
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79064/comment/565b6699_13045c4b :
PS4, Line 9: Configure I2S1 and I2C5 for ALC5650 to support beep sound in depthcharge.
`Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Done
File src/mainboard/google/corsola/mainboard.c:
https://review.coreboot.org/c/coreboot/+/79064/comment/085ea255_7703f273 :
PS4, Line 40: 5
use I2C5?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79064?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854
Gerrit-Change-Number: 79064
Gerrit-PatchSet: 6
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jiaxin Yu
jiaxin.yu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jiaxin Yu
jiaxin.yu@mediatek.corp-partner.google.com
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 10:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-MessageType: comment