Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit
......................................................................
Patch Set 24: Code-Review+1
(4 comments)
https://review.coreboot.org/#/c/30414/23//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30414/23//COMMIT_MSG@12
PS23, Line 12: manufacture
manufacturer
Done
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos...
File src/mainboard/facebook/fbg1701/cmos.layout:
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos...
PS23, Line 69: 4
Use by core, not by platform. Expect that 'h' is covering this. […]
Done
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos...
PS23, Line 91: 896 32 r 0 mrc_scrambler_seed
: 928 32 r 0 mrc_scrambler_seed_s3
Result of copy/paste from Intel Stago. […]
Done
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/roms...
File src/mainboard/facebook/fbg1701/romstage.c:
https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/roms...
PS23, Line 45: uintptr_t
possibly missing direct include
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 24
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Tue, 21 May 2019 19:33:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment