Attention is currently required from: Zhuohao Lee. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56308 )
Change subject: mb/google/brya: add BASEBOARD_DIR to support different baseboard ......................................................................
Patch Set 1:
(4 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/56308/comment/e8a4f142_d17a1037 PS1, Line 1: BOARD_GOOGLE_BASEBOARD_BRYA This will have to be updated to allow for different Kconfigs for different baseboards. Something like what zork does should work: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
* BOARD_GOOGLE_BASEBOARD_BRYA * BOARD_GOOGLE_BASEBOARD_BRASK
Are you planning to push that as a separate change?
https://review.coreboot.org/c/coreboot/+/56308/comment/1146d1c9_f8ae977c PS1, Line 37: config BASEBOARD_BRYA_LAPTOP : def_bool n : select SYSTEM_TYPE_LAPTOP There is some clean up required for this as well. I think SYSTEM_TYPE_LAPTOP should be selected for all BOARD_GOOGLE_BASEBOARD_BRYA at least for now. Maybe it can be pushed as a separate change.
https://review.coreboot.org/c/coreboot/+/56308/comment/95242a1c_f00aa24a PS1, Line 46: CHROMEOS_DRAM_PART_NUMBER_IN_CBI I think this is specific to brya baseboard. If you are planning to handle all memory differences separately, feel free to push this along with that.
https://review.coreboot.org/c/coreboot/+/56308/comment/a09f5473_9d8a0f31 PS1, Line 77: BOARD_GOOGLE_BRYA0 This will have to be changed to BOARD_GOOGLE_BASEBOARD_BRYA. Also the string should be Google_Brya.