Attention is currently required from: Jason Glenesk, ritul guru, Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73372 )
Change subject: soc/amd/phoenix: Update phoenix2 VGA BIOS ID ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/73372/comment/fb929e63_a2cbdbac PS1, Line 247: 1002,15c8
if choose VGA_BIOS_ID=1002,1205 then getting below error: […]
it's expected that the first attempt here will fail: rom_header = cbfs_boot_map_optionrom(dev->vendor, dev->device); then the remapping function map_oprom_vendev gets called and returns the vbios file that we'll need to retrieve. due to the first cbfs_boot_map_optionrom call to expectedly fail, rom_header will be NULL and due to that this code will be run rom_header = cbfs_boot_map_optionrom(mapped_vendev >> 16, mapped_vendev & 0xffff); this is how the remapping works.
When using 1002,15c8 as VGA_BIOS_ID, things will end up working for the 1002,15c8 id, since map_oprom_vendev will be called unconditionally and due to it remapping the ID, the pci id mismatch check later on will be skipped, but it's not the correct solution. in the case of the 1002,1205 device, having VGA_BIOS_ID set to 1002,15c8 won't work as expected. in that case, cbfs_boot_map_optionrom(dev->vendor, dev->device) would return null and map_oprom_vendev expectedly won't do any remapping, so the cbfs_boot_map_optionrom(mapped_vendev >> 16, mapped_vendev & 0xffff) call will also return null
-
Felix Held (Code Review)