build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57642 )
Change subject: mb/google/trogdor: Add mipi panel for wormdingler ......................................................................
Patch Set 2:
(25 comments)
File src/drivers/mipi/panel-BOE_TV110C9M_LL0.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/b133bf8d_a57e05ea PS2, Line 36: PANEL_DCS(0xB0, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/6e079b24_02a411be PS2, Line 38: PANEL_DCS(0xB1, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/0e32f1f3_0dc25612 PS2, Line 40: PANEL_DCS(0xB2, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/60d48368_0e9e8c42 PS2, Line 42: PANEL_DCS(0xB3, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/8ccbd862_bc80b2fd PS2, Line 44: PANEL_DCS(0xB4, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/077f810c_b2e3b37f PS2, Line 46: PANEL_DCS(0xB5, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/5534e5ee_35b51813 PS2, Line 48: PANEL_DCS(0xB6, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/5099d1f7_c3d9a6cc PS2, Line 50: PANEL_DCS(0xB7, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/ed4b3b50_4fbd2f6c PS2, Line 52: PANEL_DCS(0xB8, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/e87ddf88_7d50b588 PS2, Line 54: PANEL_DCS(0xB9, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/fe323543_49bab2b6 PS2, Line 56: PANEL_DCS(0xBA, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/4e6ee12a_81972edb PS2, Line 58: PANEL_DCS(0xBB, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/0149d452_cb767fb1 PS2, Line 62: PANEL_DCS(0xB0, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/94b538eb_6c0d2a11 PS2, Line 64: PANEL_DCS(0xB1, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/76267c00_9c144161 PS2, Line 66: PANEL_DCS(0xB2, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/dcb5e82d_a4ee7806 PS2, Line 68: PANEL_DCS(0xB3, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/02642c65_abf02de5 PS2, Line 70: PANEL_DCS(0xB4, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/f840a026_dc209686 PS2, Line 72: PANEL_DCS(0xB5, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/531fe1ea_642438a8 PS2, Line 74: PANEL_DCS(0xB6, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/c53a5411_7c745062 PS2, Line 76: PANEL_DCS(0xB7, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/1dd377f0_84e1334a PS2, Line 78: PANEL_DCS(0xB8, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/6a0c834a_d06d4b69 PS2, Line 80: PANEL_DCS(0xB9, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/5f63c3d1_f1e2586b PS2, Line 82: PANEL_DCS(0xBA, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/c27226f3_afc2030c PS2, Line 84: PANEL_DCS(0xBB, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128120): https://review.coreboot.org/c/coreboot/+/57642/comment/3da55724_5f9e29e2 PS2, Line 166: PANEL_DCS(0xB6, 0x05, 0x00, 0x05, 0x00, 0x00, 0x00, 0x00, 0x00, \ Avoid unnecessary line continuations
-
build bot (Jenkins) (Code Review)