Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39466 )
Change subject: mb/tglrvp: Update Audio AIC settings for Tiger Lake ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39466/6/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c:
https://review.coreboot.org/c/coreboot/+/39466/6/src/mainboard/intel/tglrvp/... PS6, Line 87: PAD_CFG_NF(GPP_S2, NONE, DEEP, NF2), /* DMIC0_CLK_B */ : PAD_CFG_NF(GPP_S3, NONE, DEEP, NF2), /* DMIC1_CLK_B */ : : PAD_CFG_NF(GPP_S4, NONE, DEEP, NF2), /* DMIC1_CLK */ : PAD_CFG_NF(GPP_S5, NONE, DEEP, NF2), /* DMIC1_DATA */ : PAD_CFG_NF(GPP_S6, NONE, DEEP, NF2), /* DMIC0_CLK */ : PAD_CFG_NF(GPP_S7, NONE, DEEP, NF2), /* DMIC0_DATA *
Can you group DMIC0 and DMIC1 like below? […]
Done
https://review.coreboot.org/c/coreboot/+/39466/6/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c:
https://review.coreboot.org/c/coreboot/+/39466/6/src/mainboard/intel/tglrvp/... PS6, Line 84: PAD_CFG_NF(GPP_S2, NONE, DEEP, NF2), /* DMIC0_CLK_B */ : PAD_CFG_NF(GPP_S3, NONE, DEEP, NF2), /* DMIC1_CLK_B */ : : PAD_CFG_NF(GPP_S4, NONE, DEEP, NF2), /* DMIC1_CLK */ : PAD_CFG_NF(GPP_S5, NONE, DEEP, NF2), /* DMIC1_DATA */ : PAD_CFG_NF(GPP_S6, NONE, DEEP, NF2), /* DMIC0_CLK */ : PAD_CFG_NF(GPP_S7, NONE, DEEP, NF2), /* DMIC0_DATA *
Can you group DMIC0 an DMIC1 like below? […]
Done
-
Srinidhi N Kaushik (Code Review)