Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19541 )
Change subject: pci_device: add PCI device IDs for Intel platforms
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/19541/5/src/include/device/pci_ids.h
File src/include/device/pci_ids.h:
PS5, Line 2673: PCI_DEVICE_ID_INTEL_KBL_LP_Y_PREMIUM 0x9d56
: #define PCI_DEVICE_ID_APOLLOLAKE_LP
Can we have a consistent naming scheme:
PCI_DEVICE_ID_INTEL_{KBL/SPT/APL}_{suffix}_{LPC/PMC/I2C0/}
--
To view, visit
https://review.coreboot.org/19541
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eee9409df3e6dc326b60bc82c2b715c70e7debd
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes