Attention is currently required from: Angel Pons.
Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/84175?usp=email )
Change subject: mb/topton/adl: Add initial support for X2F N100 FW appliance ......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/topton/adl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/84175/comment/cfed738a_b348461f?usp... : PS2, Line 43: # TODO: SATA doesn't work. EDK2 returns "Unsupported", not sure how to fix (yet).
Okay, then I would leave the SATA ports enabled in the devicetree since that's correct. […]
That's a good question, AFAIK this SoC has 8 lanes: - NVME: x2 - ETH0: x1 - ETH1: x1 - ETH2: X1 - ETH3: X1 - WiFi: X1
This leaves us with one more lane assigned... somewhere?
File src/mainboard/topton/adl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/84175/comment/cf4f20d0_c0c6493d?usp... : PS9, Line 99: chip superio/ite/it8625e
Does fan control work?
This device is fanless (using chassis as a heatsink), so no :D
File src/mainboard/topton/adl/mainboard.c:
https://review.coreboot.org/c/coreboot/+/84175/comment/1efbdcea_c28b7d4c?usp... : PS9, Line 17: params->PchLegacyIoLowLatency = 1;
Okay, fair enough. […]
ack