Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78785?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: nb/intel/sandybridge: Drop raminit_native.h ......................................................................
nb/intel/sandybridge: Drop raminit_native.h
After commit adaeb1102186 (nb/intel/sandybridge: Clean up post Haswell SPD mapping API migration), no boards use this header anymore and it no longer offers original content.
Adjust northbridge code #includes as needed and drop it.
Change-Id: I2785e920bd6188dbfc1a6157351083ec4a2526d0 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/78785 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth gaumless@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c M src/northbridge/intel/sandybridge/raminit_iosav.c M src/northbridge/intel/sandybridge/raminit_native.c D src/northbridge/intel/sandybridge/raminit_native.h 4 files changed, 1 insertion(+), 14 deletions(-)
Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index b3f913ef..c2a3051 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -11,7 +11,6 @@ #include <delay.h> #include <types.h>
-#include "raminit_native.h" #include "raminit_common.h" #include "raminit_tables.h" #include "sandybridge.h" diff --git a/src/northbridge/intel/sandybridge/raminit_iosav.c b/src/northbridge/intel/sandybridge/raminit_iosav.c index 12a3be6..fbbbfba 100644 --- a/src/northbridge/intel/sandybridge/raminit_iosav.c +++ b/src/northbridge/intel/sandybridge/raminit_iosav.c @@ -3,7 +3,6 @@ #include <commonlib/helpers.h> #include <types.h>
-#include "raminit_native.h" #include "raminit_common.h" #include "raminit_tables.h" #include "sandybridge.h" diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c index a46390c..fbdc27a 100644 --- a/src/northbridge/intel/sandybridge/raminit_native.c +++ b/src/northbridge/intel/sandybridge/raminit_native.c @@ -12,7 +12,7 @@ #include <stdbool.h> #include <stdint.h>
-#include "raminit_native.h" +#include "sandybridge.h" #include "raminit_common.h" #include "raminit_tables.h"
diff --git a/src/northbridge/intel/sandybridge/raminit_native.h b/src/northbridge/intel/sandybridge/raminit_native.h deleted file mode 100644 index fa0f2ff..0000000 --- a/src/northbridge/intel/sandybridge/raminit_native.h +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef RAMINIT_NATIVE_H -#define RAMINIT_NATIVE_H - -#include "sandybridge.h" -#include <device/dram/ddr3.h> -#include <stdbool.h> -#include <stdint.h> - -#endif /* RAMINIT_NATIVE_H */