Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56668 )
Change subject: soc/intel/cannonlake: Clear RTC_BATTERY_DEAD
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56668/comment/aabe0d15_a2002a1f
PS1, Line 11: RTC_BATTERY_DEAD
: is set
Why is that? Is it really always like this after flashing? or is this an `if`?
https://review.coreboot.org/c/coreboot/+/56668/comment/705d770a_4d70a7e7
PS1, Line 13: which clears RTC_BATTERY_DEAD towards the end of its
: execution
Is this FSP's only reaction? Doesn't it need to know the failure
state for anything else?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56668
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54f519edb9f4295f83a581db9cb43f5ae5d0d483
Gerrit-Change-Number: 56668
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 05 Sep 2021 11:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment