EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41964 )
Change subject: mb/google/deltaur: Change H1 I2C speed to FAST ......................................................................
mb/google/deltaur: Change H1 I2C speed to FAST
H1 is stable after HW rework. Connect +3.3V_ALW_PCH with +3.3V_PRIM. Therefore change I2C speed back to FAST.
BUG=b:154885320 TEST=Check H1 I2C speed is 375kHz by scope. And no error message in cbmem and kernel log.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If58721039d90514a17f024e6b432f3a5226440e7 --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/41964/1
diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index 14516a0..1af8325 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -89,7 +89,7 @@ .speed = I2C_SPEED_FAST, }, .i2c[3] = { - .speed = I2C_SPEED_STANDARD, + .speed = I2C_SPEED_FAST, .early_init = 1, }, .i2c[5] = {
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41964 )
Change subject: mb/google/deltaur: Change H1 I2C speed to FAST ......................................................................
Patch Set 1: Code-Review+2
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41964 )
Change subject: mb/google/deltaur: Change H1 I2C speed to FAST ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41964 )
Change subject: mb/google/deltaur: Change H1 I2C speed to FAST ......................................................................
mb/google/deltaur: Change H1 I2C speed to FAST
H1 is stable after HW rework. Connect +3.3V_ALW_PCH with +3.3V_PRIM. Therefore change I2C speed back to FAST.
BUG=b:154885320 TEST=Check H1 I2C speed is 375kHz by scope. And no error message in cbmem and kernel log.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If58721039d90514a17f024e6b432f3a5226440e7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41964 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Bora Guvendik bora.guvendik@intel.com --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Bora Guvendik: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index 14516a0..1af8325 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -89,7 +89,7 @@ .speed = I2C_SPEED_FAST, }, .i2c[3] = { - .speed = I2C_SPEED_STANDARD, + .speed = I2C_SPEED_FAST, .early_init = 1, }, .i2c[5] = {
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41964 )
Change subject: mb/google/deltaur: Change H1 I2C speed to FAST ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4730 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4729 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4728 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4727
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Bora Guvendik (Code Review)
-
EricR Lai (Code Review)
-
Tim Wawrzynczak (Code Review)