Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35284 )
Change subject: intel/fsp_broadwell_de: Enable CONSOLE_CBMEM by default ......................................................................
intel/fsp_broadwell_de: Enable CONSOLE_CBMEM by default
In the very early days of FSP 1.0 this did not work so we kept it disabled.
Change-Id: I8a88be6df335598d4c6007a8b7ff307b293e1f97 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/fsp_broadwell_de/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/35284/1
diff --git a/src/soc/intel/fsp_broadwell_de/Kconfig b/src/soc/intel/fsp_broadwell_de/Kconfig index c388525..9c91d7c 100644 --- a/src/soc/intel/fsp_broadwell_de/Kconfig +++ b/src/soc/intel/fsp_broadwell_de/Kconfig @@ -77,10 +77,6 @@ help Use Broadwell-DE Integrated UART ports @3F8h and 2F8h.
-config CONSOLE_CBMEM - bool "Send console output to a CBMEM buffer" - default n - config SERIRQ_CONTINUOUS_MODE bool default n
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35284 )
Change subject: intel/fsp_broadwell_de: Enable CONSOLE_CBMEM by default ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35284 )
Change subject: intel/fsp_broadwell_de: Enable CONSOLE_CBMEM by default ......................................................................
intel/fsp_broadwell_de: Enable CONSOLE_CBMEM by default
In the very early days of FSP 1.0 this did not work so we kept it disabled.
Change-Id: I8a88be6df335598d4c6007a8b7ff307b293e1f97 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35284 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/fsp_broadwell_de/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/intel/fsp_broadwell_de/Kconfig b/src/soc/intel/fsp_broadwell_de/Kconfig index c388525..9c91d7c 100644 --- a/src/soc/intel/fsp_broadwell_de/Kconfig +++ b/src/soc/intel/fsp_broadwell_de/Kconfig @@ -77,10 +77,6 @@ help Use Broadwell-DE Integrated UART ports @3F8h and 2F8h.
-config CONSOLE_CBMEM - bool "Send console output to a CBMEM buffer" - default n - config SERIRQ_CONTINUOUS_MODE bool default n
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)