Change in coreboot[master]: mb/google/brya/var/banshee: add the smbus addr for dimm1 - coreboot-gerrit

14 Apr 2022


      Attention is currently required from: Frank Wu, John Su, YH Lin, Dtrain Hsu, Ian Feng, Nick Vaccaro, Eric Lai, Amanda Hwang, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63622 )
Change subject: mb/google/brya/var/banshee: add the smbus addr for dimm1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Hi Tim and Eric, […]
Hi Frank, yeah that seems like the right thing to do, if banshee does not have those DIMMs, then it doesn't make sense to have addresses for non-existent DIMMs in the code 👍
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63622
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I708d6c3f7976891b1178e43449168090e215d122
Gerrit-Change-Number: 63622
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su john_su@compal.corp-partner.google.com
Gerrit-Attention: YH Lin yueherngl@google.com
Gerrit-Attention: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee zhuohao@chromium.org
Gerrit-Comment-Date: Thu, 14 Apr 2022 15:22:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu frank_wu@compal.corp-partner.google.com
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment