Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47834 )
Change subject: mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level ......................................................................
mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level
Change-Id: Ifca49c656f259b08fb8ab47fe36e93c146f25266 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/Makefile.inc R src/mainboard/clevo/cml-u/bootblock.c R src/mainboard/clevo/cml-u/ramstage.c M src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc 4 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/47834/1
diff --git a/src/mainboard/clevo/cml-u/Makefile.inc b/src/mainboard/clevo/cml-u/Makefile.inc index 3af82dd..de3c774 100644 --- a/src/mainboard/clevo/cml-u/Makefile.inc +++ b/src/mainboard/clevo/cml-u/Makefile.inc @@ -1,4 +1,8 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include
+bootblock-y += bootblock.c + +ramstage-y += ramstage.c ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c + subdirs-y += variants/$(VARIANT_DIR) diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/bootblock.c b/src/mainboard/clevo/cml-u/bootblock.c similarity index 100% rename from src/mainboard/clevo/cml-u/variants/l140cu/bootblock.c rename to src/mainboard/clevo/cml-u/bootblock.c diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/ramstage.c b/src/mainboard/clevo/cml-u/ramstage.c similarity index 100% rename from src/mainboard/clevo/cml-u/variants/l140cu/ramstage.c rename to src/mainboard/clevo/cml-u/ramstage.c diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc b/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc index 57ad0ca..0e47d86 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc +++ b/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc @@ -1,4 +1,2 @@ -bootblock-y += bootblock.c romstage-y += romstage.c -ramstage-y += ramstage.c SPD_SOURCES = samsung-K4AAG165WA-BCTD
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47834 )
Change subject: mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47834
to look at the new patch set (#2).
Change subject: mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level ......................................................................
mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level
Change-Id: Ifca49c656f259b08fb8ab47fe36e93c146f25266 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/Makefile.inc R src/mainboard/clevo/cml-u/bootblock.c R src/mainboard/clevo/cml-u/ramstage.c M src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc 4 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/47834/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47834
to look at the new patch set (#3).
Change subject: mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level ......................................................................
mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level
Change-Id: Ifca49c656f259b08fb8ab47fe36e93c146f25266 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/Makefile.inc R src/mainboard/clevo/cml-u/bootblock.c R src/mainboard/clevo/cml-u/ramstage.c M src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc 4 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/47834/3
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47834 )
Change subject: mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level ......................................................................
mb/clevo/cml-u: Move bootblock.c and ramstage.c to mb level
Change-Id: Ifca49c656f259b08fb8ab47fe36e93c146f25266 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/47834 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/clevo/cml-u/Makefile.inc R src/mainboard/clevo/cml-u/bootblock.c R src/mainboard/clevo/cml-u/ramstage.c M src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc 4 files changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/clevo/cml-u/Makefile.inc b/src/mainboard/clevo/cml-u/Makefile.inc index 3af82dd..de3c774 100644 --- a/src/mainboard/clevo/cml-u/Makefile.inc +++ b/src/mainboard/clevo/cml-u/Makefile.inc @@ -1,4 +1,8 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include
+bootblock-y += bootblock.c + +ramstage-y += ramstage.c ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c + subdirs-y += variants/$(VARIANT_DIR) diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/bootblock.c b/src/mainboard/clevo/cml-u/bootblock.c similarity index 100% rename from src/mainboard/clevo/cml-u/variants/l140cu/bootblock.c rename to src/mainboard/clevo/cml-u/bootblock.c diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/ramstage.c b/src/mainboard/clevo/cml-u/ramstage.c similarity index 100% rename from src/mainboard/clevo/cml-u/variants/l140cu/ramstage.c rename to src/mainboard/clevo/cml-u/ramstage.c diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc b/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc index 57ad0ca..0e47d86 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc +++ b/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc @@ -1,4 +1,2 @@ -bootblock-y += bootblock.c romstage-y += romstage.c -ramstage-y += ramstage.c SPD_SOURCES = samsung-K4AAG165WA-BCTD
-
Felix Singer (Code Review) -
Michael Niewöhner (Code Review)