[S] Change in coreboot[master]: mb/google/nissa/var/yaviks: Select VBT based on FW_CONFIG for yavilla
Attention is currently required from: Tarun Tuli.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74262 )
Change subject: mb/google/nissa/var/yaviks: Select VBT based on FW_CONFIG for yavilla ......................................................................
Patch Set 1:
(10 comments)
File src/mainboard/google/brya/variants/yaviks/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/96085e02_a14c3c7f PS1, Line 21: if (fw_config_probe(FW_CONFIG(MB_HDMI, HDMI_PRESENT))) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/692fae6a_2ffdc55d PS1, Line 21: if (fw_config_probe(FW_CONFIG(MB_HDMI, HDMI_PRESENT))) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/c463810e_84375831 PS1, Line 22: printk(BIOS_INFO, "Use vbt-yavilla.bin\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/ac90895a_33e12677 PS1, Line 22: printk(BIOS_INFO, "Use vbt-yavilla.bin\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/cbd54459_034274ac PS1, Line 23: return "vbt-yavilla.bin"; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/86867840_1d0fa3f6 PS1, Line 23: return "vbt-yavilla.bin"; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/5bbc35f3_8a27a25a PS1, Line 24: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/b4adf82f_e4c2f1ce PS1, Line 24: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/b4256a1c_05bf5d4a PS1, Line 25: printk(BIOS_INFO, "Use vbt.bin\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173644): https://review.coreboot.org/c/coreboot/+/74262/comment/9168c6fd_47c68f8f PS1, Line 25: printk(BIOS_INFO, "Use vbt.bin\n"); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)