Jeff Chase has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39109 )
Change subject: mb/google/fizz: allow 8 bit sku ids ......................................................................
mb/google/fizz: allow 8 bit sku ids
Change-Id: I663678a4c572fe80298f7388870d5cd403122b98 Signed-off-by: Jeff Chase jnchase@google.com --- M src/mainboard/google/fizz/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/39109/1
diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 9397786..89795f5 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -184,7 +184,7 @@
const char *smbios_system_sku(void) { - static char sku_str[5]; /* sku{0..7} */ + static char sku_str[7]; /* sku{0..255} */
snprintf(sku_str, sizeof(sku_str), "sku%d", board_oem_id());
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39109 )
Change subject: mb/google/fizz: allow 8 bit sku ids ......................................................................
Patch Set 1: Code-Review+2
Jeff Chase has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39109 )
Change subject: mb/google/fizz: allow 8 bit sku ids ......................................................................
Patch Set 1:
Thanks Shelley. Would you be able to submit this for me?
Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39109 )
Change subject: mb/google/fizz: allow 8 bit sku ids ......................................................................
mb/google/fizz: allow 8 bit sku ids
Change-Id: I663678a4c572fe80298f7388870d5cd403122b98 Signed-off-by: Jeff Chase jnchase@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39109 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Shelley Chen shchen@google.com --- M src/mainboard/google/fizz/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved
diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 9397786..89795f5 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -184,7 +184,7 @@
const char *smbios_system_sku(void) { - static char sku_str[5]; /* sku{0..7} */ + static char sku_str[7]; /* sku{0..255} */
snprintf(sku_str, sizeof(sku_str), "sku%d", board_oem_id());
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39109 )
Change subject: mb/google/fizz: allow 8 bit sku ids ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/885 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/884 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/883
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Jeff Chase (Code Review)
-
Shelley Chen (Code Review)