Attention is currently required from: Ravi kumar, Sudheer Amrabadi.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58545 )
Change subject: sc7280: Add Modem region to avoid modem cleanup in Secboot reboot.
......................................................................
Patch Set 21: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58545/comment/ed3ca6ac_a7a0a4d5
PS20, Line 10: developement
while you're at it, can you please fix the spelling of development?
Done
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/58545/comment/7168959a_7fd36921
PS20, Line 9: static void soc_read_resources(struct device *dev)
Somehow this newline got deleted.
This still hasn't been fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56bfb210606b08893ff71dd1b6679f1ec102ec95
Gerrit-Change-Number: 58545
Gerrit-PatchSet: 21
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: mturney mturney
quic_mturney@quicinc.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Fri, 28 Jan 2022 17:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment