Varshit B Pandya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/intel/dedede: Add Audio support ......................................................................
mb/intel/dedede: Add Audio support
1. Configure Audio GPIOs. 2. Set i2c4 configuration.
Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c 2 files changed, 29 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index e4750ec..4b372b2 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -150,7 +150,13 @@ device pci 16.4 off end # HECI 3 device pci 16.5 off end # HECI 4 device pci 17.0 off end # SATA - device pci 19.0 on end # I2C 4 + device pci 19.0 on + chip drivers/generic/max98357a + register "hid" = ""MX98360A"" + register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)" + device generic 0 on end + end + end # I2C #4 device pci 19.1 off end # I2C 5 device pci 19.2 on end # UART 2 device pci 1a.0 on end # eMMC diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index 8049040..169772b 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -13,6 +13,19 @@
/* Pad configuration in ramstage*/ static const struct pad_config gpio_table[] = { + /* R0 : I2S_HP_BCLK */ + PAD_CFG_NF(GPP_R0, NONE, DEEP, NF2), + /* R1 : I2S_HP_LRCK */ + PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2), + /* R2 : I2S_HP_AUDIO */ + PAD_CFG_NF(GPP_R2, NONE, DEEP, NF2), + /* R3 : I2S_HP_MIC */ + PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2), + /* R6 : I2S_SPK_LRCK */ + PAD_CFG_NF(GPP_R6, NONE, DEEP, NF1), + /* R7 : I2S_SPK_AUDIO */ + PAD_CFG_NF(GPP_R7, NONE, DEEP, NF1), + /* GPP_A0 thru GPP_A6 come configured out of reset, do not touch */ /* A0 : ESPI_IO0 */ /* A1 : ESPI_IO1 */ @@ -72,6 +85,13 @@ /* C23 : UART2_CTS_N */ PAD_NC(GPP_C23, DN_20K),
+ /* D16 : HP_INT_ODL*/ + AD_CFG_GPI_INT(GPP_D16, NONE, PLTRST, EDGE_BOTH), + /* D17 : EN_SPK */ + PAD_CFG_GPO(GPP_D17, 1, PLTRST), + /* D18 : I2S_MCLK */ + PAD_CFG_NF(GPP_D18, NONE, DEEP, NF1), + /* F7 : EMMC_CMD */ PAD_CFG_NF(GPP_F7, NONE, DEEP, NF1), /* F8 : EMMC_DATA0 */ @@ -126,6 +146,8 @@ PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1), /* H9 : AP_I2C_AUDIO_SCL */ PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1), + /* H15 : I2S_SPK_BCLK */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), };
/* Early pad configuration in bootblock */
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/intel/dedede: Add Audio support ......................................................................
Patch Set 1:
(12 comments)
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 19: PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 19: PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 21: PAD_CFG_NF(GPP_R2, NONE, DEEP, NF2), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 21: PAD_CFG_NF(GPP_R2, NONE, DEEP, NF2), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 23: PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 23: PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 25: PAD_CFG_NF(GPP_R6, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 25: PAD_CFG_NF(GPP_R6, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 27: PAD_CFG_NF(GPP_R7, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 27: PAD_CFG_NF(GPP_R7, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 150: PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 150: PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), please, no spaces at the start of a line
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/intel/jslrvp_waddledoo: Add Audio support ......................................................................
Patch Set 2:
This change is ready for review.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 4:
This change is ready for review.
Divagar Mohandass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 4: Code-Review+1
Verified audio spk and jack playback.
Hello build bot (Jenkins), Usha P, Divagar Mohandass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39285
to look at the new patch set (#5).
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 75 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/5
Divagar Mohandass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 5: Code-Review+1
Verified audio spk and jack playback.
Aamir Bohra has uploaded a new patch set (#7) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 75 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/7
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 101: PLTRST Why?
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36, Were these verified?
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 101: PLTRST
Why?
We can move it to deep, I thought the SPK Enable reset on PLTRST should not break any functionality and would get reconfigured in ramstage prior to boot beep requirement.
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
Were these verified?
Audio is verified working, but these parameters are not electrically verified. Will verify and update.
Aamir Bohra has uploaded a new patch set (#9) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 61 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/9
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
Audio is verified working, but these parameters are not electrically verified. […]
from the device spec:
CLKL SCL low time 500 ns CLKH SCL high time 260 ns
the count high and low count I believe need to be calculated as 133(soc clk)* scl_low(or high)_time/Khz. Correct?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36, These are dependent on board design and are from the perspective of the I2C controller. The designware controller guide provides details of how the values need to be calculated. This bug also has more details of how it was done on Reef: b/35582963. You can find similar bugs for other platforms too. I would recommend raising a bug to perform the same tuning for waddledoo and we can add these values in when the tuning is done.
Audio is verified working, but these parameters are not electrically verified.
Without proper tuning, you would see that the CLK frequency could be higher than 400kHz leading to issues talking to the device. There might not be errors observed all the time, so it is difficult to catch these unless you are running long stress tests. Easy way to check this is to monitor CLK frequency on the scope.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
These are dependent on board design and are from the perspective of the I2C controller. […]
ok, I 'll raise a crosbug for tuning, will update observation on clock frequency.
Aamir Bohra has uploaded a new patch set (#11) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 61 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/11
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
ok, I 'll raise a crosbug for tuning, will update observation on clock frequency.
I checked and see a mean around 300Khz, but not exceeding 400Khz
Aamir Bohra has uploaded a new patch set (#13) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 61 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/13
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 101: PLTRST
We can move it to deep, I thought the SPK Enable reset on PLTRST should not break any functionality […]
How does this behave with S3? Does it result in any unwanted issues on resume in OS? I know S3 is not POR, but curious about the behavior.
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
I checked and see a mean around 300Khz, but not exceeding 400Khz
We might need some more tuning to bring this close to 400. I think it would be good to raise a bug anyways since this has to be done for all I2C buses.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 101: PLTRST
How does this behave with S3? Does it result in any unwanted issues on resume in OS? I know S3 is no […]
Not tested with S3 Furquan, but since it is set for PLTRST , it would go back to default on PLTRST assertion and configured back in ramstage for boot beep and kernel usage
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
We might need some more tuning to bring this close to 400. […]
Ok, raised a bug #151302522 to track tuning
Aamir Bohra has uploaded a new patch set (#15) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 61 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/15
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 101: PLTRST
Not tested with S3 Furquan, but since it is set for PLTRST , it would go back to default on PLTRST a […]
Done
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
Ok, raised a bug #151302522 to track tuning
Done
Aamir Bohra has uploaded a new patch set (#16) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
TEST=verify codecs gets listed with aplay -l command.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 61 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/16
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39285/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39285/1//COMMIT_MSG@11 PS1, Line 11:
Tested how?
Done
Aamir Bohra has uploaded a new patch set (#17) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
TEST=Verify codecs gets listed with aplay -l command.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 61 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/17
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 17:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 19: Nit: Please put this line back.
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 3: DRIVERS_GENERIC_MAX98357A Given that only some variants use this codec and headphone jack, can you please select under the concerned variant itself?
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 16: Nit: Remove this extra line.
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 83: 1f.3 Can you please confirm if this is correct? EDS marks it as reserved.
Aamir Bohra has uploaded a new patch set (#18) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
TEST=Verify codecs gets listed with aplay -l command.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 60 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39285/18
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 18:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 19:
Nit: Please put this line back.
Done
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 3: DRIVERS_GENERIC_MAX98357A
Given that only some variants use this codec and headphone jack, can you please select under the con […]
Done
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 16:
Nit: Remove this extra line.
Done
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 83: 1f.3
Can you please confirm if this is correct? EDS marks it as reserved.
yes, I see the device getting listed in lspci
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 83: 1f.3
yes, I see the device getting listed in lspci
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 18: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
mb/google/dedede Add Audio support for waddledoo
1. Configure Audio GPIOs. 2. Set i2c4 configuration. 3. Update PCH HDA configuration
TEST=Verify codecs gets listed with aplay -l command.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Signed-off-by: Yong Zhi yong.zhi@intel.com Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39285 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 4 files changed, 60 insertions(+), 17 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index d083d2d..36c2467 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -9,6 +9,8 @@ select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_DA7219
config BOARD_GOOGLE_WADDLEDEE bool "Waddledee" diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index ece9672a..865d4ea 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -103,6 +103,14 @@ register "PcieClkSrcClkReq[4]" = "4" register "PcieClkSrcClkReq[5]" = "5"
+ # Audio related configurations + register "PchHdaDspEnable" = "1" + register "PchHdaAudioLinkHdaEnable" = "1" + register "PchHdaAudioLinkSspEnable[0]" = "1" + register "PchHdaAudioLinkSspEnable[1]" = "1" + register "PchHdaAudioLinkDmicEnable[0]" = "1" + register "PchHdaAudioLinkDmicEnable[1]" = "1" + # Enable EMMC HS400 mode register "ScsEmmcHs400Enabled" = "1"
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index 3909104..bdc3de4 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -178,11 +178,11 @@ /* D15 : UCAM_RST_L */ PAD_NC(GPP_D15, NONE), /* D16 : HP_INT_ODL */ - PAD_NC(GPP_D16, NONE), + PAD_CFG_GPI_INT(GPP_D16, NONE, PLTRST, EDGE_BOTH), /* D17 : EN_SPK */ - PAD_NC(GPP_D17, NONE), + PAD_CFG_GPO(GPP_D17, 1, PLTRST), /* D18 : I2S_MCLK */ - PAD_NC(GPP_D18, NONE), + PAD_CFG_NF(GPP_D18, NONE, DEEP, NF1), /* D19 : WWAN_WLAN_COEX1 */ PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), /* D20 : WWAN_WLAN_COEX2 */ @@ -319,7 +319,7 @@ /* H14 : GPP_H14/AVS_I2S2_RXD */ PAD_NC(GPP_H14, NONE), /* H15 : I2S_SPK_BCLK */ - PAD_NC(GPP_H15, NONE), + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H16 : AP_SUB_IO_L */ PAD_NC(GPP_H16, NONE), /* H17 : WWAN_RST_L */ @@ -330,38 +330,40 @@ PAD_CFG_GPO(GPP_H19, 1, DEEP),
/* R0 : I2S_HP_BCLK */ - PAD_NC(GPP_R0, NONE), + PAD_CFG_NF(GPP_R0, NONE, DEEP, NF2), /* R1 : I2S_HP_LRCK */ - PAD_NC(GPP_R1, NONE), + PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2), /* R2 : I2S_HP_AUDIO */ - PAD_NC(GPP_R2, NONE), + PAD_CFG_NF(GPP_R2, NONE, DEEP, NF2), /* R3 : I2S_HP_MIC */ - PAD_NC(GPP_R3, NONE), + PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2), /* R4 : GPP_R04/HDA_RST_N */ PAD_NC(GPP_R4, NONE), /* R5 : GPP_R05/HDA_SDI1/AVS_I2S1_RXD */ PAD_NC(GPP_R5, NONE), /* R6 : I2S_SPK_LRCK */ - PAD_NC(GPP_R6, NONE), - /* R7 : I2S_SPK_AUDIO */ - PAD_NC(GPP_R7, NONE), + PAD_CFG_NF(GPP_R6, NONE, DEEP, NF1), + /* R7 : I2S_SPK_AUDIO */ + PAD_CFG_NF(GPP_R7, NONE, DEEP, NF1), +
/* S0 : RAM_STRAP_4 */ PAD_NC(GPP_S0, NONE), /* S1 : RSVD_STRAP */ PAD_NC(GPP_S1, NONE), /* S2 : DMIC1_CLK */ - PAD_NC(GPP_S2, NONE), + PAD_CFG_NF(GPP_S2, NONE, DEEP, NF2), /* S3 : DMIC1_DATA */ - PAD_NC(GPP_S3, NONE), + PAD_CFG_NF(GPP_S3, NONE, DEEP, NF2), /* S4 : GPP_S04/SNDW1_CLK */ PAD_NC(GPP_S4, NONE), /* S5 : GPP_S05/SNDW1_DATA */ PAD_NC(GPP_S5, NONE), - /* S6 : DMIC0_CLK */ - PAD_NC(GPP_S6, NONE), + /* S6 : DMIC0_CLK */ + PAD_CFG_NF(GPP_S6, NONE, DEEP, NF2), /* S7 : DMIC0_DATA */ - PAD_NC(GPP_S7, NONE), + PAD_CFG_NF(GPP_S7, NONE, DEEP, NF2), +
/* GPD0 : AP_BATLOW_L */ PAD_CFG_NF(GPD0, NONE, DEEP, NF1), diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb index 9860e3d..884199c 100644 --- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb @@ -36,6 +36,12 @@ }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 176, + .scl_hcnt = 95, + .sda_hold = 36, + } }, }" device domain 0 on @@ -49,12 +55,37 @@ device i2c 15 on end end end #I2C 0 - device pci 1c.7 on chip drivers/intel/wifi register "wake" = "GPE0_DW2_03" device pci 00.0 on end end end # PCI Express Root Port 8 - WLAN + device pci 19.0 on + chip drivers/i2c/da7219 + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" + register "btn_cfg" = "50" + register "mic_det_thr" = "500" + register "jack_ins_deb" = "20" + register "jack_det_rate" = ""32ms_64ms"" + register "jack_rem_deb" = "1" + register "a_d_btn_thr" = "0xa" + register "d_b_btn_thr" = "0x16" + register "b_c_btn_thr" = "0x21" + register "c_mic_btn_thr" = "0x3e" + register "btn_avg" = "4" + register "adc_1bit_rpt" = "1" + register "micbias_lvl" = "2600" + register "mic_amp_in_sel" = ""diff"" + device i2c 1a on end + end + end #I2C 4 + device pci 1f.3 on + chip drivers/generic/max98357a + register "hid" = ""MX98360A"" + register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)" + device generic 0 on end + end + end # Intel HDA end end
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 19:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1477 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1476 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1475
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aamir Bohra (Code Review)
-
build bot (Jenkins) (Code Review)
-
Divagar Mohandass (Code Review)
-
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Varshit B Pandya (Code Review)