HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33804
Change subject: cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t ......................................................................
cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t
Change-Id: I11e4792804f0f7b5a7ce504c46654c1bff775c32 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/33804/1
diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index b3ffb3d..fb5c5f3 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -185,7 +185,7 @@ void *stacks_top; size_t size; char *base; - int i; + size_t i; struct smm_stub_params *stub_params; struct rmodule smm_stub;
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33804 )
Change subject: cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33804 )
Change subject: cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t ......................................................................
Patch Set 2: Code-Review+1
Did some tool find this?
Hello Jacob Garber, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33804
to look at the new patch set (#3).
Change subject: cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t ......................................................................
cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t
Spotted out using -Wconversion gcc warning option.
Change-Id: I11e4792804f0f7b5a7ce504c46654c1bff775c32 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/33804/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33804 )
Change subject: cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33804 )
Change subject: cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t ......................................................................
cpu/x86/smm/smm_module_loader: Compare num_concurrent_stacks to size_t
Spotted out using -Wconversion gcc warning option.
Change-Id: I11e4792804f0f7b5a7ce504c46654c1bff775c32 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33804 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index b3ffb3d..fb5c5f3 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -185,7 +185,7 @@ void *stacks_top; size_t size; char *base; - int i; + size_t i; struct smm_stub_params *stub_params; struct rmodule smm_stub;