Change in ...coreboot[master]: src/arch/x86/acpigen: Compare dev_states_count to size_t

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33803

Change subject: src/arch/x86/acpigen: Compare dev_states_count to size_t
......................................................................

src/arch/x86/acpigen: Compare dev_states_count to size_t

Change-Id: Ib882cfa6d429fbfcab2b8132280182b427d510aa
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33803/1

diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index 74cd25a..f9af102 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -1115,7 +1115,7 @@
 void acpigen_write_power_res(const char *name, uint8_t level, uint16_t order,
    		     const char *dev_states[], size_t dev_states_count)
 {
-	int i;
+	size_t i;
    for (i = 0; i < dev_states_count; i++) {
    	acpigen_write_name(dev_states[i]);
    	acpigen_write_package(1);

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33803 )

Change subject: src/arch/x86/acpigen: Compare dev_states_count to size_t
......................................................................

Patch Set 1: Code-Review+2

Change in coreboot[master]: src/arch/x86/acpigen: Compare dev_states_count to size_t

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33803 )

Change subject: src/arch/x86/acpigen: Compare dev_states_count to size_t
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: src/arch/x86/acpigen: Compare dev_states_count to size_t

[HAOUAS Elyes (Code Review)]

Hello Jacob Garber, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33803

to look at the new patch set (#3).

Change subject: src/arch/x86/acpigen: Compare dev_states_count to size_t
......................................................................

src/arch/x86/acpigen: Compare dev_states_count to size_t

Spotted out using -Wconversion gcc warning option.

Change-Id: Ib882cfa6d429fbfcab2b8132280182b427d510aa
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpigen.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33803/3

Change in coreboot[master]: src/arch/x86/acpigen: Compare dev_states_count to size_t

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33803 )

Change subject: src/arch/x86/acpigen: Compare dev_states_count to size_t
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: src/arch/x86/acpigen: Compare dev_states_count to size_t

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33803 )

Change subject: src/arch/x86/acpigen: Compare dev_states_count to size_t
......................................................................

src/arch/x86/acpigen: Compare dev_states_count to size_t

Spotted out using -Wconversion gcc warning option.

Change-Id: Ib882cfa6d429fbfcab2b8132280182b427d510aa
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33803
Reviewed-by: Angel Pons 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/arch/x86/acpigen.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index 74cd25a..f9af102 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -1115,7 +1115,7 @@
 void acpigen_write_power_res(const char *name, uint8_t level, uint16_t order,
    		     const char *dev_states[], size_t dev_states_count)
 {
-	int i;
+	size_t i;
    for (i = 0; i < dev_states_count; i++) {
    	acpigen_write_name(dev_states[i]);
    	acpigen_write_package(1);