Attention is currently required from: Kenneth Chan, Rob Barnes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59839 )
Change subject: mb/google/guybrush/dewatt: initial dewatt device config ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59839/comment/34b2291a_ed4695c0 PS2, Line 7: initial dewatt device config Please make it a statement by adding a verb (in imperative mood):
Ad initial …
https://review.coreboot.org/c/coreboot/+/59839/comment/cddc4f40_18740fb9 PS2, Line 7: dewatt var/dewatt
https://review.coreboot.org/c/coreboot/+/59839/comment/39adbb74_f79755cf PS2, Line 7: initial There is already some device configuration? Why “initial”?
https://review.coreboot.org/c/coreboot/+/59839/comment/3362bccb_df3eb4b2 PS2, Line 11: 5682 , Please remove the space.
https://review.coreboot.org/c/coreboot/+/59839/comment/6b237ad1_e0a0596a PS2, Line 9: add Synaptics S9831 touch pad for dewatt : add Elan 6918 touch screen for dewatt : add Realtek 5682 , ALC1019 for dewatt Please format it as a list.
https://review.coreboot.org/c/coreboot/+/59839/comment/3bd0f0cc_475c82d1 PS2, Line 12: Where did you get the “data” from. Please meantion the datasheet (name, revision) or schematics revision.
-
Paul Menzel (Code Review)