Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79760?usp=email )
Change subject: nb/intel/sandybridge/raminit: Drop write to BANDTIMERS_SNB ......................................................................
nb/intel/sandybridge/raminit: Drop write to BANDTIMERS_SNB
MRC.bin doesn't write BANDTIMERS_SNB register, so drop the write. The bits written were targeting a reserved range, so assume it didn't do anything useful.
Tested on Lenovo X220: Still boots and runs fine.
Change-Id: I920aabd60831c791188af976914553787cc0ff18 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/79760 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index f896541..d6d545c 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -2865,7 +2865,6 @@
mchbar_setbits32(MC_INIT_STATE_G, 1 << 0); mchbar_setbits32(MC_INIT_STATE_G, 1 << 7); - mchbar_write32(BANDTIMERS_SNB, 0xfa);
/* Find a populated channel */ FOR_ALL_POPULATED_CHANNELS