Attention is currently required from: Mathew King, Tim Wawrzynczak, Paul Menzel, Rob Barnes, Karthik Ramasubramanian.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50882 )
Change subject: mb/google/guybrush: Set up FW_CONFIG fields
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Patchset:
PS5:
Tim do we need an empty fw_config in devicetree?
In discussing this with Tim, neither of us feel that we should need the empty fw_config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8f30f6d7c4781d4e8451546b39395a74393608f
Gerrit-Change-Number: 50882
Gerrit-PatchSet: 7
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 17:11:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment