Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39397 )
Change subject: util/scripts/gerrit-rebase: Fix shell invocation ......................................................................
util/scripts/gerrit-rebase: Fix shell invocation
The single apostrophe confuses the shell that's calling the command.
Change-Id: I7d3183e9a612de0121b2d208c06a45645b8d67f6 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/scripts/gerrit-rebase 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/39397/1
diff --git a/util/scripts/gerrit-rebase b/util/scripts/gerrit-rebase index d051103..27ee3c7 100755 --- a/util/scripts/gerrit-rebase +++ b/util/scripts/gerrit-rebase @@ -71,7 +71,7 @@ cut -d: -f2-)"
# start rebase process, but fail immediately by enforcing an invalid todo -GIT_SEQUENCE_EDITOR="echo Ignore this error, it's intentional>" \ +GIT_SEQUENCE_EDITOR="echo 'Ignore this error, it works around a git-rebase limitation'>" \ git rebase -i --onto ${to} ${from} ${to} 2>/dev/null
# write new rebase todo
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39397 )
Change subject: util/scripts/gerrit-rebase: Fix shell invocation ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39397 )
Change subject: util/scripts/gerrit-rebase: Fix shell invocation ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39397 )
Change subject: util/scripts/gerrit-rebase: Fix shell invocation ......................................................................
util/scripts/gerrit-rebase: Fix shell invocation
The single apostrophe confuses the shell that's calling the command.
Change-Id: I7d3183e9a612de0121b2d208c06a45645b8d67f6 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39397 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/scripts/gerrit-rebase 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/util/scripts/gerrit-rebase b/util/scripts/gerrit-rebase index d051103..27ee3c7 100755 --- a/util/scripts/gerrit-rebase +++ b/util/scripts/gerrit-rebase @@ -71,7 +71,7 @@ cut -d: -f2-)"
# start rebase process, but fail immediately by enforcing an invalid todo -GIT_SEQUENCE_EDITOR="echo Ignore this error, it's intentional>" \ +GIT_SEQUENCE_EDITOR="echo 'Ignore this error, it works around a git-rebase limitation'>" \ git rebase -i --onto ${to} ${from} ${to} 2>/dev/null
# write new rebase todo
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39397 )
Change subject: util/scripts/gerrit-rebase: Fix shell invocation ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1480 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1479 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1478
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)