Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45008 )
Change subject: util/intelp2m: Update macros ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Agree, it would be nice to fix those. Please make another patch for that if you can
https://review.coreboot.org/c/coreboot/+/45008/2/util/intelp2m/platforms/snr... File util/intelp2m/platforms/snr/macro.go:
https://review.coreboot.org/c/coreboot/+/45008/2/util/intelp2m/platforms/snr... PS2, Line 93: // PAD_CFG_GPI_APIC_INVERT(pad, pull, rst)
this comment contains an old macro. Please remove or update it.
Ack
https://review.coreboot.org/c/coreboot/+/45008/2/util/intelp2m/platforms/snr... PS2, Line 132: // e.g. PAD_CFG_GPI_ACPI_SCI(GPP_G2, NONE, DEEP, YES), : // #define PAD_CFG_GPI_ACPI_SCI(pad, pull, rst, inv) \ : // PAD_CFG_GPI_SCI(pad, pull, rst, EDGE_SINGLE, inv)
same
Ack
https://review.coreboot.org/c/coreboot/+/45008/2/util/intelp2m/platforms/snr... PS2, Line 150: // e.g. PAD_CFG_GPI_ACPI_SMI(GPP_I3, NONE, DEEP, YES),
same
Ack
-
Stefan Reinauer (Code Review)