Maximilian Brune has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87203?usp=email )
Change subject: doc/contributing/git_commit_messages: fix line length ......................................................................
doc/contributing/git_commit_messages: fix line length
The line length limit in the commit messages is 72 characters, not 75, so fix the value in the documentation. The 72 characters also matches what checkpatch checks for.
Change-Id: I2ec0fbd78fd0b054eae7bf9d6bd30580f47deb8f Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/87203 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maximilian Brune maximilian.brune@9elements.com Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M Documentation/contributing/git_commit_messages.md 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Maximilian Brune: Looks good to me, approved Matt DeVillier: Looks good to me, approved
diff --git a/Documentation/contributing/git_commit_messages.md b/Documentation/contributing/git_commit_messages.md index 4addf4c..a007b2a 100644 --- a/Documentation/contributing/git_commit_messages.md +++ b/Documentation/contributing/git_commit_messages.md @@ -13,14 +13,14 @@ ## Line length
- The subject line should be <= 65 characters, with an absolute maximum - of 75 characters -- Prose in the commit message should be <= 75 characters -- If reflowing prose to 75 characters can reduce the length of the + of 72 characters +- Prose in the commit message should be <= 72 characters +- If reflowing prose to 72 characters can reduce the length of the commit message by 2 or more lines, please reflow it. Using the entire - 75 characters on a line when reasonable is recommended, but not + 72 characters on a line when reasonable is recommended, but not required. - Non-prose text in the body in the commit message does not need to be - wrapped at 75 characters. Examples: URLs, compiler output, or poetry. + wrapped at 72 characters. Examples: URLs, compiler output, or poetry.
## Both Subject & body