Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54077 )
Change subject: soc/amd: factor out acpigen_write_alib_dptc to common code
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/acpi/alib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119069):
https://review.coreboot.org/c/coreboot/+/54077/comment/4f5b06e8_4ba7a2be
PS1, Line 28: /* TODO: The code assumes that if DPTC gets called the folowing object exists */
'folowing' may be misspelled - perhaps 'following'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1e2aa1ec728a4e16d3a587d7400cdfc8962f443
Gerrit-Change-Number: 54077
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 11 May 2021 23:53:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment