Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51704 )
Change subject: soc/intel/alderlake: Align RcompResistor definition as per MRC ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51704/comment/cde7ecc3_db5cf9c8 PS2, Line 10: Reference RCOMP resistors on motherboard ~ 100 Ohms but coreboot
Missing a verb? […]
Ack
https://review.coreboot.org/c/coreboot/+/51704/comment/94dcffb7_13861261 PS2, Line 11: Rcmp
typo: `Rc*o*mp`
Ack
File src/soc/intel/alderlake/include/soc/meminit.h:
https://review.coreboot.org/c/coreboot/+/51704/comment/47111524_020be1bf PS2, Line 22: values
nit: singular `value`
Ack
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/51704/comment/fb8cd40e_2cc1fc13 PS2, Line 20: &
While this shouldn't cause issues (the pointer value is the same), I'd still drop the `&`
Ack