Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31134 )
Change subject: soc/intel/cannonlake: Make SOC_INTEL_CANNONLAKE_MEMCFG_INIT common for CFL/WHL SoC
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31134/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31134/1//COMMIT_MSG@7
PS1, Line 7: SOC_INTEL_CANNONLAKE_MEMCFG_INIT
i don't think we are even using cnlrvp today hence didn't bother to make changes on something that n […]
My point is you can get rid of this config option completely.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib21ea305871dc859e7db0720c18a9479100346c3
Gerrit-Change-Number: 31134
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Jan 2019 17:59:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment