Change in coreboot[master]: mb/google/hatch/var/jinlon: Fix EPS disabling procedure

[Nico Huber (Code Review)]

Attention is currently required from: Matt DeVillier.
Hello Matt DeVillier,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/62592

to review the following change.

Change subject: mb/google/hatch/var/jinlon: Fix EPS disabling procedure
......................................................................

mb/google/hatch/var/jinlon: Fix EPS disabling procedure

It looks like commit ebf1482627 (mb/google/hatch/var/jinlon: Switch to
using device pointers) accidentally switched off the iGPU instead of
the generic device representing the Electronic Privacy Screen (EPS)
below it.

The find_gfx_dev() function used prior to ebf1482627 should have
returned the generic device, too.

Change-Id: Iaf5dcb85fbee4386851f822e0087a92cf3434e47
Signed-off-by: Nico Huber 
Fixes: commit ebf1482627 (mb/google/hatch/var/jinlon: Switch to using device pointers)
---
M src/mainboard/google/hatch/variants/jinlon/mainboard.c
M src/mainboard/google/hatch/variants/jinlon/overridetree.cb
2 files changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/62592/1

diff --git a/src/mainboard/google/hatch/variants/jinlon/mainboard.c b/src/mainboard/google/hatch/variants/jinlon/mainboard.c
index d2e5b43..51ef346 100644
--- a/src/mainboard/google/hatch/variants/jinlon/mainboard.c
+++ b/src/mainboard/google/hatch/variants/jinlon/mainboard.c
@@ -20,20 +20,20 @@

static void check_for_eps(uint32_t sku_id)
 {
-	struct device *gfx_dev = DEV_PTR(igpu);
+	struct device *eps_dev = DEV_PTR(eps);

if (eps_sku(sku_id)) {
    	printk(BIOS_INFO, "SKU ID %u has EPS\n", sku_id);
    	return;
    }

-	if (!gfx_dev) {
+	if (!eps_dev) {
    	printk(BIOS_ERR, "Error! No EPS dev, view-angle-management won't work\n");
    	return;
    }

printk(BIOS_INFO, "SKU ID %u doesn't have EPS, disabling...\n", sku_id);
-	gfx_dev->enabled = 0;
+	eps_dev->enabled = 0;
 }

void variant_devtree_update(void)
diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb
index b3887d4..a51f892 100644
--- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb
@@ -69,7 +69,7 @@
    register "ScsEmmcHs400Enabled" = "1"

device domain 0 on
-		device pci 02.0 alias igpu on	# Integrated Graphics Device
+		device pci 02.0 on	# Integrated Graphics Device
    		register "gfx" = "GMA_DEFAULT_PANEL(0)"
    	end
    	device pci 02.0 on
@@ -80,7 +80,7 @@
    			register "device[0].addr" = "0x80010400"
    			register "device[0].privacy.enabled" = "1"
    			register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E0)"
-				device generic 0 on end
+				device generic 0 alias eps on end
    		end
    	end # Integrated Graphics Device
                 device pci 14.0 on