Change in ...coreboot[master]: drivers/i2c/max98373: Set default bus speed as I2C_SPEED_FAST
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31407
Change subject: drivers/i2c/max98373: Set default bus speed as I2C_SPEED_FAST ......................................................................
drivers/i2c/max98373: Set default bus speed as I2C_SPEED_FAST
This change sets default bus speed as I2C_SPEED_FAST instead of I2C_SPEED_STANDARD when board does not provide any speed. This makes it similar to all other i2c drivers in coreboot.
BUG=b:124403846 BRANCH=nocturne,atlas
Change-Id: I877d837eea2dfebf78ad7d97a32ee2071500625e Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/i2c/max98373/max98373.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/31407/1
diff --git a/src/drivers/i2c/max98373/max98373.c b/src/drivers/i2c/max98373/max98373.c index e10ccf1..0431c2e 100644 --- a/src/drivers/i2c/max98373/max98373.c +++ b/src/drivers/i2c/max98373/max98373.c @@ -34,7 +34,7 @@ struct acpi_i2c i2c = { .address = dev->path.i2c.device, .mode_10bit = dev->path.i2c.mode_10bit, - .speed = config->bus_speed ? : I2C_SPEED_STANDARD, + .speed = config->bus_speed ? : I2C_SPEED_FAST, .resource = scope, }; struct acpi_dp *dp;
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31407 )
Change subject: drivers/i2c/max98373: Set default bus speed as I2C_SPEED_FAST ......................................................................
Patch Set 1: Code-Review+2
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31407 )
Change subject: drivers/i2c/max98373: Set default bus speed as I2C_SPEED_FAST ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31407 )
Change subject: drivers/i2c/max98373: Set default bus speed as I2C_SPEED_FAST ......................................................................
drivers/i2c/max98373: Set default bus speed as I2C_SPEED_FAST
This change sets default bus speed as I2C_SPEED_FAST instead of I2C_SPEED_STANDARD when board does not provide any speed. This makes it similar to all other i2c drivers in coreboot.
BUG=b:124403846 BRANCH=nocturne,atlas
Change-Id: I877d837eea2dfebf78ad7d97a32ee2071500625e Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/31407 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/drivers/i2c/max98373/max98373.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Sumeet R Pawnikar: Looks good to me, approved
diff --git a/src/drivers/i2c/max98373/max98373.c b/src/drivers/i2c/max98373/max98373.c index e10ccf1..0431c2e 100644 --- a/src/drivers/i2c/max98373/max98373.c +++ b/src/drivers/i2c/max98373/max98373.c @@ -34,7 +34,7 @@ struct acpi_i2c i2c = { .address = dev->path.i2c.device, .mode_10bit = dev->path.i2c.mode_10bit, - .speed = config->bus_speed ? : I2C_SPEED_STANDARD, + .speed = config->bus_speed ? : I2C_SPEED_FAST, .resource = scope, }; struct acpi_dp *dp;
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Sumeet R Pawnikar (Code Review)