Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant - coreboot-gerrit

4 Nov 2018


      Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x...
File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x...
PS5, Line 79:
...
The SPI Guide suggests to fill both for maximum compatibility. And […]
Thanks for clarifying, the PCH datasheet doesn't explain 'upper' and 'lower'.
-- 
To view, visit https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 04 Nov 2018 14:53:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No