Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Piotr Król.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email )
Change subject: superio/ite: Add special fan vectors, unify it8722f with common ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/jecht/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81310/comment/6358c58b_382e4ff3 : PS1, Line 84: FAN2.pwm_start needs to be `FAN2.smart.pwm_start`
File src/superio/ite/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/81310/comment/9fc1c83a_04014e59 : PS1, Line 90: void ite_set_3vsbsw(pnp_devfn_t dev, bool enable) not sure I see the point in changing this, given the disable option isn't used anywhere. At the very least, I'd keep the enable function as a call to `ite_set_3vsbsw()` so that none of the callers have to actually change
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81310/comment/732a32bf_f7463685 : PS1, Line 364: if (CONFIG(SUPERIO_ITE_ENV_CTRL_FAN_VECTOR)) { needs to be #ifdef'd since the `fan_vector` field doesn't exist if the config isn't set