Attention is currently required from: Lance Zhao, Jason Glenesk, Raul Rangel, Matt DeVillier, Sridhar Siricilla, Arthur Heymans, Kyösti Mälkki, Fred Reitberger, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74316 )
Change subject: sb,soc/amd,intel: Add and use ACPI_COMMON_MADT_LAPIC
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2:
Tried to match Kconfig and code changes, only found asus/p2b unmatched.
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74316/comment/7d0d1023_92012c9e
PS2, Line 296: if (CONFIG(ACPI_COMMON_MADT_LAPIC))
Not sure if this should be guarded by !ACPI_NO_MADT as well. Looking
through the affected boards, I found asus/p2b which selects ACPI_NO_MADT
but gets ACPI_COMMON_MADT_LAPIC selected now. It wouldn't be wrong
I guess. But if the change is expected, it should be noted in the commit
message.
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74316/comment/c9623cb4_be499de8
PS2, Line 90: ACPI_COMMON_MADT_LAPIC
I would prefer to keep the original SOC_INTEL_COMMON_ACPI_CPU_HYBRID. If
by any chance in the future, ACPI_COMMON_MADT_LAPIC wouldn't be selected
by accident, this could get quite confusing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74316
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f8d7ee9891553742d73a92b55a87c04fa95a132
Gerrit-Change-Number: 74316
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 12 Apr 2023 22:31:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment