Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Lance Zhao, Subrata Banik, Sukumar Ghorai, Tarun, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78164?usp=email )
Change subject: soc/intel: Fix slp-s0 residency counter frequency LPIT table
......................................................................
Patch Set 11:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78164/comment/76dc713d_4ce8ec09 :
PS11, Line 7: soc/intel
soc/intel/mtl
https://review.coreboot.org/c/coreboot/+/78164/comment/bff232a3_e5d7e61f :
PS11, Line 7: Fix slp-s0 residency counter frequency LPIT table
Maybe:
Set slp-s0 residency counter frequency to …
https://review.coreboot.org/c/coreboot/+/78164/comment/688ef2ed_1d9e2be7 :
PS11, Line 16: meteorlake
Meteor Lake
https://review.coreboot.org/c/coreboot/+/78164/comment/d87cb964_b992c4f3 :
PS11, Line 20: cat /sys/devices/system/cpu/cpuidle/low_power_idle_system_residency_us
: cat /sys/kernel/debug/pmc_core/slp_s0_residency_usec
Please also paste the content.
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/78164/comment/f5ffd3fb_4a08dc3a :
PS11, Line 442: ACPI_SOC_INTEL_SLP_S0_FREQ
Add the unit?
https://review.coreboot.org/c/coreboot/+/78164/comment/f021aee7_72422052 :
PS11, Line 444: 0x2005
How many μs is that?
https://review.coreboot.org/c/coreboot/+/78164/comment/32ed5ff9_9202a621 :
PS11, Line 446: meteorlake
Meteor Lake
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78164?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I401dd4a09a67d81a9ea3a56cd22f1a681e2a9349
Gerrit-Change-Number: 78164
Gerrit-PatchSet: 11
Gerrit-Owner: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 05 Oct 2023 21:48:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment