Attention is currently required from: Alexander Couzens, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58752 )
Change subject: lenovo/g505s: add the PIRQ routing table ......................................................................
Patch Set 1:
(15 comments)
File src/mainboard/lenovo/g505s/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/3903515a_5bf6f315 PS1, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/490cc937_a8fc06fa PS1, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/7d6604ee_b1cdb2ab PS1, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/83e1f4de_2cb55bf5 PS1, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/77762c69_345a4560 PS1, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/8958895b_7c73e8c0 PS1, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/d99429f3_04208378 PS1, Line 35: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/e226cfcf_03ebb2d6 PS1, Line 37: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/7c2f1e6d_0bac6101 PS1, Line 40: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/4ebe6dbb_38e382c8 PS1, Line 43: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/7537972f_9e250058 PS1, Line 46: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/31c79fc0_f207b938 PS1, Line 49: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/c97db62d_00b93e2e PS1, Line 51: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x1, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/643f8010_2e891c43 PS1, Line 53: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x2, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131815): https://review.coreboot.org/c/coreboot/+/58752/comment/7474de53_a5352207 PS1, Line 55: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90}, {0x01, 0xdc90} }, 0x3, 0x0} line over 96 characters
-
build bot (Jenkins) (Code Review)