build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29406 )
Change subject: NOT_FOR_MERGE soc/amd/stoneridge: Add DRAM check for s3 ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.... File src/soc/amd/stoneyridge/s3test_util.c:
https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.... PS1, Line 249: wbinvd(); code indent should use tabs where possible
https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.... PS1, Line 249: wbinvd(); please, no space before tabs
https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.... PS1, Line 249: wbinvd(); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.... PS1, Line 251: err = 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.... PS1, Line 251: err = 0; please, no space before tabs
https://review.coreboot.org/#/c/29406/1/src/soc/amd/stoneyridge/s3test_util.... PS1, Line 251: err = 0; please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)