Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33984
Change subject: util/romcc: Correct format specifiers ......................................................................
util/romcc: Correct format specifiers
The right specifier for printing ptrdiff_t is %td.
Change-Id: I7bae4d47f15cfe85ca870f687c6f702339f680bb Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 14021{64,68,76} --- M util/romcc/romcc.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33984/1
diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index 2a158e5..378bfc5 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -19873,7 +19873,7 @@ else { return 1; } - cgdebug_printf(state, " %d\n", range - rstate->lr); + cgdebug_printf(state, " %td\n", range - rstate->lr); range->group_prev = 0; for(edge = range->edges; edge; edge = edge->next) { struct live_range *node; @@ -19891,7 +19891,7 @@ if (&node->group_next == rstate->high_tail) { rstate->high_tail = node->group_prev; } - cgdebug_printf(state, "Moving...%d to low\n", node - rstate->lr); + cgdebug_printf(state, "Moving...%td to low\n", node - rstate->lr); node->group_prev = rstate->low_tail; node->group_next = 0; *rstate->low_tail = node; @@ -19904,7 +19904,7 @@ } colored = color_graph(state, rstate); if (colored) { - cgdebug_printf(state, "Coloring %d @", range - rstate->lr); + cgdebug_printf(state, "Coloring %td @", range - rstate->lr); cgdebug_loc(state, range->defs->def); cgdebug_flush(state); colored = select_free_color(state, rstate, range); @@ -20198,7 +20198,7 @@ */ if ((range->degree < regc_max_size(state, range->classes)) || (range->color != REG_UNSET)) { - cgdebug_printf(state, "Lo: %5d degree %5d%s\n", + cgdebug_printf(state, "Lo: %5td degree %5d%s\n", range - rstate.lr, range->degree, (range->color != REG_UNSET) ? " (colored)": ""); *range->group_prev = range->group_next; @@ -20215,7 +20215,7 @@ next = point; } else { - cgdebug_printf(state, "hi: %5d degree %5d%s\n", + cgdebug_printf(state, "hi: %5td degree %5d%s\n", range - rstate.lr, range->degree, (range->color != REG_UNSET) ? " (colored)": ""); }
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33984 )
Change subject: util/romcc: Correct format specifiers ......................................................................
Patch Set 1: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33984 )
Change subject: util/romcc: Correct format specifiers ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33984 )
Change subject: util/romcc: Correct format specifiers ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33984 )
Change subject: util/romcc: Correct format specifiers ......................................................................
util/romcc: Correct format specifiers
The right specifier for printing ptrdiff_t is %td.
Change-Id: I7bae4d47f15cfe85ca870f687c6f702339f680bb Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 14021{64,68,76} Reviewed-on: https://review.coreboot.org/c/coreboot/+/33984 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/romcc/romcc.c 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, but someone else must approve
diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index 2a158e5..378bfc5 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -19873,7 +19873,7 @@ else { return 1; } - cgdebug_printf(state, " %d\n", range - rstate->lr); + cgdebug_printf(state, " %td\n", range - rstate->lr); range->group_prev = 0; for(edge = range->edges; edge; edge = edge->next) { struct live_range *node; @@ -19891,7 +19891,7 @@ if (&node->group_next == rstate->high_tail) { rstate->high_tail = node->group_prev; } - cgdebug_printf(state, "Moving...%d to low\n", node - rstate->lr); + cgdebug_printf(state, "Moving...%td to low\n", node - rstate->lr); node->group_prev = rstate->low_tail; node->group_next = 0; *rstate->low_tail = node; @@ -19904,7 +19904,7 @@ } colored = color_graph(state, rstate); if (colored) { - cgdebug_printf(state, "Coloring %d @", range - rstate->lr); + cgdebug_printf(state, "Coloring %td @", range - rstate->lr); cgdebug_loc(state, range->defs->def); cgdebug_flush(state); colored = select_free_color(state, rstate, range); @@ -20198,7 +20198,7 @@ */ if ((range->degree < regc_max_size(state, range->classes)) || (range->color != REG_UNSET)) { - cgdebug_printf(state, "Lo: %5d degree %5d%s\n", + cgdebug_printf(state, "Lo: %5td degree %5d%s\n", range - rstate.lr, range->degree, (range->color != REG_UNSET) ? " (colored)": ""); *range->group_prev = range->group_next; @@ -20215,7 +20215,7 @@ next = point; } else { - cgdebug_printf(state, "hi: %5d degree %5d%s\n", + cgdebug_printf(state, "hi: %5td degree %5d%s\n", range - rstate.lr, range->degree, (range->color != REG_UNSET) ? " (colored)": ""); }
-
HAOUAS Elyes (Code Review) -
Jacob Garber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)