Attention is currently required from: Rocky Phagura, Angel Pons, Arthur Heymans, Werner Zeh, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54343 )
Change subject: cpu/x86/smm: Fix u32 type mismatch in print statement
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
yep %zx should be the correct one. […]
stefanct suggested that in #coreboot@irc.libera.chat.
I was mainly led on the wrong path, but the warning saying the result is u32, and wanted to use the corresponding length modifier.
From fizzie in ##c:
,cc uint32_t u = 0; size_t s = 0; __typeof__(u - s) combined; ptype(u); ptype(s); ptype(combined);
→ u = unsigned int s = unsigned long combined = unsigned long
,cc -m32 uint32_t u = 0; size_t s = 0; __typeof__(u - s) combined; ptype(u); ptype(s); ptype(combined);
→ u = unsigned int s = unsigned int combined = unsigned int
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib504bc5e5b19f62d4702b7f485522a2ee3d26685
Gerrit-Change-Number: 54343
Gerrit-PatchSet: 6
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 27 May 2021 15:25:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment