Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59853 )
Change subject: soc/intel/tigerlake: Define soc_get_pcie_rp_type
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
https://review.coreboot.org/c/coreboot/+/59853/comment/48393eea_d38babd9
PS1, Line 120: /*
: * For PCIe RTD3 support, each SoC that uses it must implement this function.
: */
nit ?
/* For PCIe RTD3 support, each SoC that uses it must implement this function. */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59853
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f7d3f2fc12ae2b53604cd8f8b694a7674c3620
Gerrit-Change-Number: 59853
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 03 Dec 2021 06:01:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment