Change in ...coreboot[master]: mb/facebook/fbg1701: Remove unused Kconfig symbols

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Arthur Heymans (Code Review)

17 Jun 2019 17 Jun '19

3:39 p.m.

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33562

Change subject: mb/facebook/fbg1701: Remove unused Kconfig symbols ......................................................................

mb/facebook/fbg1701: Remove unused Kconfig symbols

Change-Id: Ifc61fd11c9d7a4d192eaae73c5421f643d27d817 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/33562/1

diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 3f45194..b3c589d 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -78,14 +78,6 @@ bool default n

-config BOOTBLOCK_LOC - hex - default 0xFFFF0000 - -config BOOTBLOCK_SIZE - hex - default 0x10000 - config SPI_FLASH_INCLUDE_ALL_DRIVERS bool default n

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Frans Hendriks (Code Review)

18 Jun 18 Jun

12:48 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33562 )

Change subject: mb/facebook/fbg1701: Remove unused Kconfig symbols ......................................................................

Patch Set 1: Code-Review-1

https://review.coreboot.org/c/coreboot/+/33463 is using these CONFIG values.

Are you aware of any alternatives for these CONFIGs?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc61fd11c9d7a4d192eaae73c5421f643d27d817 Gerrit-Change-Number: 33562 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 18 Jun 2019 10:48:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

12:53 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33562 )

Change subject: mb/facebook/fbg1701: Remove unused Kconfig symbols ......................................................................

Patch Set 1:

...

Patch Set 1: Code-Review-1

https://review.coreboot.org/c/coreboot/+/33463 is using these CONFIG values.

Are you aware of any alternatives for these CONFIGs?

I just did not see them hooked up.

You can fetch the bootblock size and location during runtime?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc61fd11c9d7a4d192eaae73c5421f643d27d817 Gerrit-Change-Number: 33562 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 18 Jun 2019 10:53:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

2:48 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33562 )

Change subject: mb/facebook/fbg1701: Remove unused Kconfig symbols ......................................................................

Patch Set 1:

...

Patch Set 1:

...
Patch Set 1: Code-Review-1

https://review.coreboot.org/c/coreboot/+/33463 is using these CONFIG values.

Are you aware of any alternatives for these CONFIGs?

I just did not see them hooked up.

You can fetch the bootblock size and location during runtime?

I will check if using CONFIG_C_ENV_BOOTBLOCK_SIZE works fine.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc61fd11c9d7a4d192eaae73c5421f643d27d817 Gerrit-Change-Number: 33562 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 18 Jun 2019 12:48:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

19 Jun 19 Jun

12:35 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33562 )

Change subject: mb/facebook/fbg1701: Remove unused Kconfig symbols ......................................................................

Patch Set 1: Code-Review+2

Use of C_ENV_BOOTBLOCK_SIZE works fine. Will update https://review.coreboot.org/c/coreboot/+/33463

-- To view, visit https://review.coreboot.org/c/coreboot/+/33562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc61fd11c9d7a4d192eaae73c5421f643d27d817 Gerrit-Change-Number: 33562 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 19 Jun 2019 10:35:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

20 Jun 20 Jun

3:19 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33562 )

Change subject: mb/facebook/fbg1701: Remove unused Kconfig symbols ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc61fd11c9d7a4d192eaae73c5421f643d27d817 Gerrit-Change-Number: 33562 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 20 Jun 2019 01:19:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

21 Jun 21 Jun

1:55 p.m.

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33562 )

Change subject: mb/facebook/fbg1701: Remove unused Kconfig symbols ......................................................................

mb/facebook/fbg1701: Remove unused Kconfig symbols

Change-Id: Ifc61fd11c9d7a4d192eaae73c5421f643d27d817 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33562 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)

Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved

-config BOOTBLOCK_LOC - hex - default 0xFFFF0000 - -config BOOTBLOCK_SIZE - hex - default 0x10000 - config SPI_FLASH_INCLUDE_ALL_DRIVERS bool default n

-- To view, visit https://review.coreboot.org/c/coreboot/+/33562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc61fd11c9d7a4d192eaae73c5421f643d27d817 Gerrit-Change-Number: 33562 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1919

days inactive

1923

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Felix Held (Code Review)
Frans Hendriks (Code Review)