Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31735 )
Change subject: util/amdfwtool: Split type field for PSP entries
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31735/4/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/31735/4/util/amdfwtool/amdfwtool.c@571
PS4, Line 571: sub = 0; /* subprogram is N/A but clear anyway */
I don't understand why you're updating sub in any of them other than 'S'. […]
Ok, I get it now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31735
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8f33000c31cba21f286f54459de185c21e46268
Gerrit-Change-Number: 31735
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Wed, 06 Mar 2019 23:34:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment